Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos #2637

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Conversation

chuanchang
Copy link
Contributor

s/deamon/daemon/, s/lable/label/, s/fo/for/

Signed-off-by: Alex Jia chuanchang.jia@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #2637 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2637      +/-   ##
=========================================
+ Coverage   69.57%   69.6%   +0.03%     
=========================================
  Files         280     280              
  Lines       18844   18844              
=========================================
+ Hits        13111   13117       +6     
+ Misses       4268    4261       -7     
- Partials     1465    1466       +1
Flag Coverage Δ
#criv1alpha1test 31.23% <ø> (-0.18%) ⬇️
#criv1alpha2test 35.69% <ø> (-0.02%) ⬇️
#integrationtest 41.71% <ø> (+0.03%) ⬆️
#nodee2etest 32.78% <ø> (+0.04%) ⬆️
#unittest 26.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 59.43% <ø> (-0.67%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha2/cri_wrapper.go 65.59% <0%> (-1.21%) ⬇️
cri/v1alpha2/cri.go 67.82% <0%> (-0.25%) ⬇️
daemon/mgr/container.go 59% <0%> (ø) ⬆️
ctrd/container.go 59.28% <0%> (+1.18%) ⬆️
daemon/mgr/container_utils.go 85.11% <0%> (+1.19%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
ctrd/image.go 78.18% <0%> (+2.27%) ⬆️
... and 1 more

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @chuanchang
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangqh zhuangqh merged commit 4a4fc2d into AliyunContainerService:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants