Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in comment #2639

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jan 2, 2019

Signed-off-by: zhangyue zy675793960@yeah.net

Ⅰ. Describe what this PR did

As the title desc.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need.

Ⅳ. Describe how to verify it

wait for CI

Ⅴ. Special notes for reviews

None.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #2639 into master will decrease coverage by 38.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2639       +/-   ##
==========================================
- Coverage   69.55%   31.4%   -38.15%     
==========================================
  Files         280     275        -5     
  Lines       18844   18711      -133     
==========================================
- Hits        13107    5877     -7230     
- Misses       4268   11815     +7547     
+ Partials     1469    1019      -450
Flag Coverage Δ
#criv1alpha1test 31.4% <ø> (+0.04%) ⬆️
#criv1alpha2test ?
#integrationtest ?
#nodee2etest ?
#unittest ?
Impacted Files Coverage Δ
pkg/jsonstream/format.go 100% <ø> (ø) ⬆️
client/container_restart.go 0% <0%> (-100%) ⬇️
client/image_pull.go 0% <0%> (-100%) ⬇️
apis/opts/sysctl.go 0% <0%> (-100%) ⬇️
client/volume_create.go 0% <0%> (-100%) ⬇️
client/image_remove.go 0% <0%> (-100%) ⬇️
client/daemon_update.go 0% <0%> (-100%) ⬇️
client/container_update.go 0% <0%> (-100%) ⬇️
client/image_load.go 0% <0%> (-100%) ⬇️
client/container_commit.go 0% <0%> (-100%) ⬇️
... and 207 more

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @ZYecho
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

Signed-off-by: zhangyue <zy675793960@yeah.net>
@allencloud
Copy link
Collaborator

LGTM, thanks @ZYecho

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 2, 2019
@allencloud allencloud merged commit b19f669 into AliyunContainerService:master Jan 2, 2019
@ZYecho ZYecho deleted the fix-typos branch January 2, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/typo LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants