Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to make TestRunRestartPolicyNone case happy #2656

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: ziren.wzr ziren.wzr@alibaba-inc.com

Ⅰ. Describe what this PR did

As the TestRunRestartPolicyNone becomes a flaky test case, so we have to try to make it happy

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: ziren.wzr <ziren.wzr@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@22bfd53). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2656   +/-   ##
=========================================
  Coverage          ?   69.66%           
=========================================
  Files             ?      283           
  Lines             ?    18891           
  Branches          ?        0           
=========================================
  Hits              ?    13160           
  Misses            ?     4264           
  Partials          ?     1467
Flag Coverage Δ
#criv1alpha1test 31.49% <ø> (?)
#criv1alpha2test 35.79% <ø> (?)
#integrationtest 41.77% <ø> (?)
#nodee2etest 32.92% <ø> (?)
#unittest 26.94% <ø> (?)

@rudyfly
Copy link
Collaborator

rudyfly commented Jan 9, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 9, 2019
@rudyfly rudyfly merged commit c7620be into AliyunContainerService:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants