test: change test image #2657
Merged
test: change test image #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
- Coverage 69.61% 68.04% -1.57%
==========================================
Files 283 283
Lines 18900 18900
==========================================
- Hits 13157 12861 -296
- Misses 4269 4587 +318
+ Partials 1474 1452 -22
|
HusterWan
reviewed
Jan 10, 2019
test/cli_container_commit_test.go
Outdated
| @@ -64,7 +64,7 @@ func (suite *PouchCommitSuite) TestCommitHardLink(c *check.C) { | |||
| cname := "TestCommitHardLink" | |||
| image := "foo:hardlink" | |||
|
|
|||
| ret := command.PouchRun("run", "-t", "--name", cname, "busybox", "sh", "-c", "touch file1 && ln file1 file2 && ls -di file1 file2") | |||
| ret := command.PouchRun("run", "-t", "--name", cname, busyboxImage, "sh", "-c", "touch file1 && ln file1 file2 && ls -di file1 file2") | |||
There was a problem hiding this comment.
convert one line to multi line?
change test image to `busyboxImage` Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
rudyfly
force-pushed
the
change_test_image
branch
from
aa7b371 to
b88f459
Compare
|
PTAL @HusterWan |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
change test image to
busyboxImageⅡ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
just modify test case.
Ⅳ. Describe how to verify it
test case:
TestCommitHardLink,TestLogsOpt,TestLogsWithDetailspassⅤ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com