bugfix: /etc/mtab will miss quota id #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if set `/etc/mtab` before set rootfs quota, it will make /etc/mtab miss quota id of rootfs quota, so it need be moved after set rootfs quota. with overlay work dir, it disappear `work/work`, when only set the dir `work`'s quota id, if we remove set dir quota id by recursively, the quota id for overlay is invalid. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
=========================================
+ Coverage 69.18% 69.2% +0.01%
=========================================
Files 285 285
Lines 18958 18959 +1
=========================================
+ Hits 13117 13120 +3
Misses 4371 4371
+ Partials 1470 1468 -2
|
Ace-Tang
reviewed
Jan 18, 2019
| @@ -231,6 +231,10 @@ func SetRootfsDiskQuota(basefs, size string, quotaID uint32) (uint32, error) { | |||
| if err := SetDiskQuota(dir, size, quotaID); err != nil { | |||
| return 0, errors.Wrapf(err, "failed to set dir(%s) disk quota", dir) | |||
| } | |||
|
|
|||
| if err := SetQuotaForDir(dir, quotaID); err != nil { | |||
There was a problem hiding this comment.
Does this operate slow start time when lot of files locates
There was a problem hiding this comment.
No, because of overlay Upper and Work have no files.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
if set
/etc/mtabbefore set rootfs quota, it will make /etc/mtab missquota id of rootfs quota, so it need be moved after set rootfs quota.
with overlay work dir, it disappear
work/work, when only set the dirwork's quota id, if we remove set dir quota id by recursively, thequota id for overlay is invalid.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
I have no good idea
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com