Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: move to 1.2.0 #2683

Merged
merged 1 commit into from
Jan 23, 2019
Merged

upgrade: move to 1.2.0 #2683

merged 1 commit into from
Jan 23, 2019

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Jan 23, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Ⅰ. Describe what this PR did

release PouchContainer

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #2683 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2683     +/-   ##
=========================================
- Coverage   69.28%   69.18%   -0.1%     
=========================================
  Files         285      285             
  Lines       18975    18975             
=========================================
- Hits        13146    13128     -18     
- Misses       4352     4368     +16     
- Partials     1477     1479      +2
Flag Coverage Δ
#criv1alpha1test 31.32% <ø> (+0.02%) ⬆️
#criv1alpha2test 35.86% <ø> (-0.06%) ⬇️
#integrationtest 41.99% <ø> (+0.02%) ⬆️
#nodee2etest 32.07% <ø> (+0.03%) ⬆️
#unittest 26.97% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
cri/v1alpha2/cri.go 71.01% <0%> (-0.63%) ⬇️
daemon/mgr/container_utils.go 83.92% <0%> (+0.59%) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented Jan 23, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 23, 2019
@rudyfly rudyfly merged commit b1b1f95 into AliyunContainerService:master Jan 23, 2019
@fuweid fuweid deleted the v1.2.0 branch March 25, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants