-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix wrongly update cpu-quota to 0 #2684
Merged
rudyfly
merged 1 commit into
AliyunContainerService:master
from
HusterWan:zr/fix-cpuquota
Jan 24, 2019
Merged
bugfix: fix wrongly update cpu-quota to 0 #2684
rudyfly
merged 1 commit into
AliyunContainerService:master
from
HusterWan:zr/fix-cpuquota
Jan 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
+ Coverage 66.85% 67.46% +0.61%
==========================================
Files 276 278 +2
Lines 17361 17392 +31
==========================================
+ Hits 11606 11734 +128
+ Misses 4490 4338 -152
- Partials 1265 1320 +55
|
HusterWan
force-pushed
the
zr/fix-cpuquota
branch
4 times, most recently
from
January 23, 2019 08:58
2d2837d
to
f2d635a
Compare
HusterWan
force-pushed
the
zr/fix-cpuquota
branch
from
January 24, 2019 03:55
f2d635a
to
9d395d4
Compare
HusterWan
force-pushed
the
zr/fix-cpuquota
branch
2 times, most recently
from
January 24, 2019 06:15
ccc62e3
to
67b1823
Compare
Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/fix-cpuquota
branch
from
January 24, 2019 06:24
67b1823
to
b6a3f7b
Compare
LGTM |
1 similar comment
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Jan 24, 2019
zjumoon01
reviewed
Jan 24, 2019
} | ||
containerID := result[0].ID | ||
|
||
if string(result[0].HostConfig.CPUQuota) == cpuQuota { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it should be "!=" rather than "=="
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
On kernel,
cpu.cfs_quota_us
only support:So
0
is not a valid value for cpu-quota, we can use0
to distinct not set from other values in api. In PouchContainer API:Ⅱ. Does this pull request fix one issue?
fix: #2538
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add test case: PouchUpdateSuite.TestUpdateContainerCPUQuota
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews