Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: shouldn't use string to convert int64 to string #2690

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

I made a mistake to use string to convert a int64 to string, in this PR, I would like to fix it.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #2690 into master will decrease coverage by 12.99%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2690     +/-   ##
========================================
- Coverage   69.19%   56.2%    -13%     
========================================
  Files         278     273      -5     
  Lines       17392   17236    -156     
========================================
- Hits        12035    9688   -2347     
- Misses       4028    6193   +2165     
- Partials     1329    1355     +26
Flag Coverage Δ
#criv1alpha2_test ?
#integration_test_0 36.23% <ø> (ø) ⬆️
#integration_test_1 35.17% <ø> (ø) ⬆️
#integration_test_2 36.28% <ø> (-0.03%) ⬇️
#integration_test_3 35.11% <ø> (-0.04%) ⬇️
#node_e2e_test 35.06% <ø> (+0.02%) ⬆️
#unittest ?
Impacted Files Coverage Δ
client/container_restart.go 0% <0%> (-100%) ⬇️
client/image_pull.go 0% <0%> (-100%) ⬇️
apis/opts/sysctl.go 0% <0%> (-100%) ⬇️
client/volume_create.go 0% <0%> (-100%) ⬇️
client/image_remove.go 0% <0%> (-100%) ⬇️
client/daemon_update.go 0% <0%> (-100%) ⬇️
client/container_update.go 0% <0%> (-100%) ⬇️
client/image_load.go 0% <0%> (-100%) ⬇️
client/container_commit.go 0% <0%> (-100%) ⬇️
client/checkpoint_create.go 0% <0%> (-100%) ⬇️
... and 137 more

@rudyfly
Copy link
Collaborator

rudyfly commented Jan 24, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 24, 2019
Signed-off-by: Michael Wan <zirenwan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants