Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change oss endpoint #2692

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Jan 24, 2019

Ⅰ. Describe what this PR did

change oss endpoint from beijing to hangkong

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #2692 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   69.11%   69.15%   +0.03%     
==========================================
  Files         278      278              
  Lines       17392    17392              
==========================================
+ Hits        12021    12027       +6     
+ Misses       4041     4038       -3     
+ Partials     1330     1327       -3
Flag Coverage Δ
#criv1alpha2_test 39.28% <ø> (-0.03%) ⬇️
#integration_test_0 36.2% <ø> (-0.07%) ⬇️
#integration_test_1 35.17% <ø> (ø) ⬆️
#integration_test_2 36.28% <ø> (-0.03%) ⬇️
#integration_test_3 35.06% <ø> (+0.05%) ⬆️
#node_e2e_test 35.08% <ø> (+0.12%) ⬆️
#unittest 27.36% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
daemon/mgr/container_utils.go 83.33% <0%> (-0.6%) ⬇️
cri/v1alpha2/cri.go 71.39% <0%> (-0.13%) ⬇️
ctrd/container.go 57.27% <0%> (+0.76%) ⬆️
cri/ocicni/cni_manager.go 70.58% <0%> (+11.76%) ⬆️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 25, 2019
hack/install/config.sh Outdated Show resolved Hide resolved
change oss endpoint from beijing to hangkong

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@rudyfly
Copy link
Collaborator Author

rudyfly commented Jan 25, 2019

PTAL @fuweid

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants