test: increate the memory limit to TestRunWithMemoryswap2x #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the CVE-2019-5736, the runC will copy the binary during initializing process in container. The binary is about 11M so that it will make the case fail. Based on this, we should increate to 20m. Signed-off-by: Wei Fu <fuweid89@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
==========================================
- Coverage 69.35% 69.29% -0.07%
==========================================
Files 278 278
Lines 17462 17462
==========================================
- Hits 12111 12100 -11
- Misses 4023 4035 +12
+ Partials 1328 1327 -1
|
fuweid
requested review from
chuanchang and
Ace-Tang
and removed request for
chuanchang
Ace-Tang
approved these changes
Feb 14, 2019
|
Refer to opencontainers/runc#1980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
For the CVE-2019-5736, the runC will copy the binary during initializing
process in container. The binary is about 11M so that it will make the
case fail. Based on this, we should increate to 20m.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
CI
Ⅴ. Special notes for reviews