Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extend annotation field of memory swap #2711

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wang allen.wq@alipay.com

Ⅰ. Describe what this PR did

Update extend annotation field of memory swap to io.alibaba.pouch.resources.memory-swap.

Ⅱ. Does this pull request fix one issue?

No.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: allen.wang <allen.wq@alipay.com>
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #2711 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2711      +/-   ##
==========================================
- Coverage   69.32%   69.27%   -0.05%     
==========================================
  Files         278      278              
  Lines       17462    17462              
==========================================
- Hits        12105    12097       -8     
- Misses       4027     4032       +5     
- Partials     1330     1333       +3
Flag Coverage Δ
#criv1alpha2_test 39.61% <ø> (+0.02%) ⬆️
#integration_test_0 36.32% <ø> (ø) ⬆️
#integration_test_1 35.29% <ø> (+0.13%) ⬆️
#integration_test_2 36.32% <ø> (+0.11%) ⬆️
#integration_test_3 35.14% <ø> (+0.05%) ⬆️
#node_e2e_test 35.01% <ø> (-0.05%) ⬇️
#unittest 27.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
daemon/mgr/events.go 89.04% <0%> (-2.74%) ⬇️
pkg/streams/utils.go 89.28% <0%> (-2.39%) ⬇️
ctrd/client.go 64.04% <0%> (-1.69%) ⬇️
cri/v1alpha2/cri.go 71.28% <0%> (-0.65%) ⬇️
ctrd/container.go 57.66% <0%> (+0.38%) ⬆️
daemon/mgr/container.go 59.91% <0%> (+0.41%) ⬆️
daemon/mgr/container_utils.go 85.11% <0%> (+1.19%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️

@wangforthinker
Copy link
Contributor Author

ping @zhuangqh

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
using - instead of _ to unify annotation naming style.

@zhuangqh zhuangqh merged commit 3a9ced1 into AliyunContainerService:master Feb 14, 2019
@wangforthinker wangforthinker deleted the feature/update-annotation-memory-swap-field branch March 15, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants