Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo #2715

Merged
merged 1 commit into from
Feb 18, 2019
Merged

fix: fix typo #2715

merged 1 commit into from
Feb 18, 2019

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Feb 18, 2019

Signed-off-by: zhangyue zy675793960@yeah.net

Ⅰ. Describe what this PR did

use IsRunningOrPaused to judge instead of use isRunning || isPaused

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

No need

Ⅳ. Describe how to verify it

wait for CI

Ⅴ. Special notes for reviews

first pr in 2019.

Signed-off-by: zhangyue <zy675793960@yeah.net>
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@df58349). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2715   +/-   ##
=========================================
  Coverage          ?   69.18%           
=========================================
  Files             ?      278           
  Lines             ?    17486           
  Branches          ?        0           
=========================================
  Hits              ?    12098           
  Misses            ?     4046           
  Partials          ?     1342
Flag Coverage Δ
#criv1alpha2_test 39.64% <0%> (?)
#integration_test_0 36.34% <0%> (?)
#integration_test_1 35.24% <0%> (?)
#integration_test_2 36.6% <0%> (?)
#integration_test_3 35.01% <0%> (?)
#node_e2e_test 34.92% <0%> (?)
#unittest 27.35% <0%> (?)
Impacted Files Coverage Δ
daemon/mgr/network.go 73.15% <0%> (ø)
daemon/mgr/container.go 59.01% <0%> (ø)

@pouchrobot pouchrobot added areas/typo kind/bug This is bug report for project size/XS labels Feb 18, 2019
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @ZYecho
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 18, 2019
@allencloud allencloud merged commit 71a7487 into AliyunContainerService:master Feb 18, 2019
@ZYecho ZYecho deleted the fix-typo branch February 22, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/typo kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants