-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cri: remove useless code #2721
Merged
rudyfly
merged 1 commit into
AliyunContainerService:master
from
fuweid:upstream-me-remove-useless-functions
Feb 22, 2019
Merged
pkg/cri: remove useless code #2721
rudyfly
merged 1 commit into
AliyunContainerService:master
from
fuweid:upstream-me-remove-useless-functions
Feb 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 69.26% 69.68% +0.42%
==========================================
Files 278 277 -1
Lines 17486 17370 -116
==========================================
- Hits 12111 12104 -7
+ Misses 4035 3924 -111
- Partials 1340 1342 +2
|
for user code, lgtm, since we use runc package to reslove , for exec code, maybe @rudyfly need to check? |
For the user, we aleady uses the functions provided by runc vendor. Therefore we remove it. Signed-off-by: Wei Fu <fuweid89@gmail.com>
zhuangqh
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM actually dead code
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
For the user, we aleady uses the functions provided by runc vendor.
Therefore we remove it.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
no need
Ⅳ. Describe how to verify it
CI
Ⅴ. Special notes for reviews