-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support annotation in container update api #2726
Merged
rudyfly
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/add-specannotation-in-container-update
Feb 26, 2019
Merged
support annotation in container update api #2726
rudyfly
merged 1 commit into
AliyunContainerService:master
from
wangforthinker:feature/add-specannotation-in-container-update
Feb 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: allen.wang <allen.wq@alipay.com>
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
===========================================
- Coverage 69.7% 51.08% -18.62%
===========================================
Files 278 276 -2
Lines 17381 17350 -31
===========================================
- Hits 12115 8864 -3251
- Misses 3924 7475 +3551
+ Partials 1342 1011 -331
|
ping @rudyfly |
ping @Ace-Tang |
Ace-Tang
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangforthinker
force-pushed
the
feature/add-specannotation-in-container-update
branch
2 times, most recently
from
February 26, 2019 03:34
68be976
to
080430d
Compare
CI failed. |
wangforthinker
force-pushed
the
feature/add-specannotation-in-container-update
branch
from
February 26, 2019 06:07
080430d
to
9f96857
Compare
ping @rudyfly |
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Feb 26, 2019
wangforthinker
deleted the
feature/add-specannotation-in-container-update
branch
March 15, 2019 03:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wang allen.wq@alipay.com
Ⅰ. Describe what this PR did
Support to update annotations in Container Update API.
Ⅱ. Does this pull request fix one issue?
fix #2724.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add test TestUpdateAnnotation.
Ⅳ. Describe how to verify it
by CI test.
Ⅴ. Special notes for reviews