Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support annotation in container update api #2726

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wang allen.wq@alipay.com

Ⅰ. Describe what this PR did

Support to update annotations in Container Update API.

Ⅱ. Does this pull request fix one issue?

fix #2724.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add test TestUpdateAnnotation.

Ⅳ. Describe how to verify it

by CI test.

Ⅴ. Special notes for reviews

Signed-off-by: allen.wang <allen.wq@alipay.com>
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #2726 into master will decrease coverage by 18.61%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2726       +/-   ##
===========================================
- Coverage    69.7%   51.08%   -18.62%     
===========================================
  Files         278      276        -2     
  Lines       17381    17350       -31     
===========================================
- Hits        12115     8864     -3251     
- Misses       3924     7475     +3551     
+ Partials     1342     1011      -331
Flag Coverage Δ
#criv1alpha2_test ?
#integration_test_0 ?
#integration_test_1 ?
#integration_test_2 ?
#integration_test_3 ?
#node_e2e_test 35.3% <0%> (+0.03%) ⬆️
#unittest 27.52% <0%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container_utils.go 79.54% <0%> (-4.39%) ⬇️
daemon/mgr/container.go 34.37% <0%> (-24.64%) ⬇️
daemon/logger/logmessage.go 0% <0%> (-100%) ⬇️
hookplugins/containerplugin/update_hook.go 0% <0%> (-100%) ⬇️
pkg/httputils/http_error.go 0% <0%> (-100%) ⬇️
apis/server/container_bridge.go 0% <0%> (-90.45%) ⬇️
apis/server/volume_bridge.go 0% <0%> (-87.18%) ⬇️
cri/v1alpha2/container_unpause.go 0% <0%> (-81.82%) ⬇️
cri/v1alpha2/container_pause.go 0% <0%> (-81.82%) ⬇️
daemon/mgr/volume.go 8.16% <0%> (-74.49%) ⬇️
... and 101 more

@wangforthinker
Copy link
Contributor Author

ping @rudyfly

@wangforthinker
Copy link
Contributor Author

ping @Ace-Tang

Copy link
Contributor

@Ace-Tang Ace-Tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangforthinker wangforthinker force-pushed the feature/add-specannotation-in-container-update branch 2 times, most recently from 68be976 to 080430d Compare February 26, 2019 03:34
@rudyfly
Copy link
Collaborator

rudyfly commented Feb 26, 2019

CI failed.

@wangforthinker wangforthinker force-pushed the feature/add-specannotation-in-container-update branch from 080430d to 9f96857 Compare February 26, 2019 06:07
@wangforthinker
Copy link
Contributor Author

ping @rudyfly

@rudyfly
Copy link
Collaborator

rudyfly commented Feb 26, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 26, 2019
@rudyfly rudyfly merged commit 69919be into AliyunContainerService:master Feb 26, 2019
@wangforthinker wangforthinker deleted the feature/add-specannotation-in-container-update branch March 15, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add specAnnotation update in container update api.
4 participants