Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: skip error when failed to set disk quota #2741

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Mar 11, 2019

Ⅰ. Describe what this PR did

skip error when failed to set disk quota, make all path have been set
disk quota, and make the contaienr to run.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

skip error when failed to set disk quota, make all path have been set
disk quota, and make the contaienr to run.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@rudyfly rudyfly requested a review from zjumoon01 March 11, 2019 06:10
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #2741 into master will decrease coverage by 1.94%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   69.37%   67.42%   -1.95%     
==========================================
  Files         278      278              
  Lines       17447    17447              
==========================================
- Hits        12103    11763     -340     
- Misses       4021     4402     +381     
+ Partials     1323     1282      -41
Flag Coverage Δ
#criv1alpha2_test 39.44% <0%> (-0.07%) ⬇️
#integration_test_0 36.56% <0%> (-0.05%) ⬇️
#integration_test_1 ?
#integration_test_2 36.56% <0%> (ø) ⬆️
#integration_test_3 35.38% <0%> (-0.06%) ⬇️
#node_e2e_test 35.34% <0%> (-0.03%) ⬇️
#unittest 28.43% <0%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/mgr/container_storage.go 59.91% <0%> (-0.82%) ⬇️
ctrd/image_commit.go 0% <0%> (-68.03%) ⬇️
daemon/mgr/container_commit.go 0% <0%> (-56.1%) ⬇️
daemon/mgr/container_checkpoint.go 54.21% <0%> (-14.46%) ⬇️
daemon/mgr/events.go 79.45% <0%> (-12.33%) ⬇️
daemon/mgr/network_utils.go 25.58% <0%> (-11.63%) ⬇️
pkg/reference/def.go 77.77% <0%> (-11.12%) ⬇️
apis/server/network_bridge.go 57.25% <0%> (-8.88%) ⬇️
daemon/mgr/container_exec.go 71.54% <0%> (-8.14%) ⬇️
apis/server/container_bridge.go 82.86% <0%> (-7.59%) ⬇️
... and 20 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Mar 11, 2019
@wangforthinker
Copy link
Contributor

LGTM

1 similar comment
@zjumoon01
Copy link
Contributor

LGTM

@wangforthinker wangforthinker merged commit b4ac324 into AliyunContainerService:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants