Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrd: ignore not found error in clean process #2742

Merged
merged 1 commit into from
Mar 11, 2019
Merged

ctrd: ignore not found error in clean process #2742

merged 1 commit into from
Mar 11, 2019

Conversation

Ace-Tang
Copy link
Contributor

in remove container, we get a clean process, but it only take effect
when unexpect error happen, so ignore error in delete task if container
is not exist, that means remove container is successful.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

in remove container, we get a clean process, but it only take effect
when unexpect error happen, so ignore error in delete task if container
is not exist, that means remove container is successful.

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #2742 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
- Coverage   69.41%   69.34%   -0.07%     
==========================================
  Files         278      278              
  Lines       17447    17448       +1     
==========================================
- Hits        12110    12100      -10     
- Misses       4014     4023       +9     
- Partials     1323     1325       +2
Flag Coverage Δ
#criv1alpha2_test 39.46% <100%> (-0.08%) ⬇️
#integration_test_0 36.59% <0%> (-0.01%) ⬇️
#integration_test_1 35.54% <0%> (+0.02%) ⬆️
#integration_test_2 36.54% <0%> (-0.03%) ⬇️
#integration_test_3 35.31% <0%> (-0.12%) ⬇️
#node_e2e_test 35.36% <100%> (ø) ⬆️
#unittest 28.43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
ctrd/container.go 57.36% <100%> (+0.84%) ⬆️
cri/stream/portforward/httpstream.go 70.94% <0%> (-6.84%) ⬇️
daemon/mgr/events.go 89.04% <0%> (-2.74%) ⬇️
cri/stream/runtime.go 67.85% <0%> (-2.39%) ⬇️
ctrd/client.go 64.04% <0%> (-1.69%) ⬇️
cri/v1alpha2/cri.go 71.88% <0%> (-0.26%) ⬇️
daemon/mgr/container.go 60.96% <0%> (+0.2%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Mar 11, 2019
@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 11, 2019
@rudyfly
Copy link
Collaborator

rudyfly commented Mar 11, 2019

LGTM

@rudyfly rudyfly merged commit ac1a952 into AliyunContainerService:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants