Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test run faster #2747

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Mar 14, 2019

Ⅰ. Describe what this PR did

build integration test binary to run test.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

build integration test binary to run test.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2747 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   69.32%   69.39%   +0.06%     
==========================================
  Files         277      277              
  Lines       17391    17391              
==========================================
+ Hits        12056    12068      +12     
+ Misses       4012     4000      -12     
  Partials     1323     1323
Flag Coverage Δ
#criv1alpha2_test 39.37% <ø> (+0.01%) ⬆️
#integration_test_0 36.51% <ø> (-0.04%) ⬇️
#integration_test_1 35.74% <ø> (-0.07%) ⬇️
#integration_test_2 36.47% <ø> (-0.01%) ⬇️
#integration_test_3 35.5% <ø> (+0.07%) ⬆️
#node_e2e_test 35.24% <ø> (ø) ⬆️
#unittest 28.54% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
cri/v1alpha2/cri.go 71.24% <0%> (-0.39%) ⬇️
ctrd/container.go 57.17% <0%> (+0.95%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
ctrd/client.go 69.39% <0%> (+1.63%) ⬆️
daemon/mgr/container_utils.go 83.52% <0%> (+1.7%) ⬆️
daemon/mgr/events.go 91.78% <0%> (+2.73%) ⬆️
pkg/streams/utils.go 89.28% <0%> (+7.14%) ⬆️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 64c7cd1 into AliyunContainerService:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants