Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pull image before using it #2755

Merged
merged 1 commit into from
Mar 18, 2019
Merged

test: pull image before using it #2755

merged 1 commit into from
Mar 18, 2019

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Mar 17, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Ⅰ. Describe what this PR did

pull image before using it in test suite

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

CI

Ⅴ. Special notes for reviews

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid requested review from rudyfly and ZYecho March 17, 2019 10:04
@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #2755 into master will increase coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2755     +/-   ##
=========================================
+ Coverage   68.12%   69.43%   +1.3%     
=========================================
  Files         277      277             
  Lines       17412    17412             
=========================================
+ Hits        11862    12090    +228     
+ Misses       4199     3999    -200     
+ Partials     1351     1323     -28
Flag Coverage Δ
#criv1alpha2_test 39.4% <ø> (+0.13%) ⬆️
#integration_test_0 36.57% <ø> (-0.02%) ⬇️
#integration_test_1 35.78% <ø> (-0.03%) ⬇️
#integration_test_2 36.44% <ø> (-0.14%) ⬇️
#integration_test_3 35.55% <ø> (+0.1%) ⬆️
#node_e2e_test 35.32% <ø> (?)
#unittest 28.51% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 82.38% <0%> (-0.57%) ⬇️
ctrd/image.go 69.96% <0%> (+0.76%) ⬆️
daemon/mgr/container.go 60.75% <0%> (+1.25%) ⬆️
daemon/mgr/spec_linux.go 78.77% <0%> (+1.43%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/client.go 69.39% <0%> (+1.63%) ⬆️
cri/v1alpha2/cri_utils.go 87.81% <0%> (+1.85%) ⬆️
cri/stream/remotecommand/httpstream.go 46.63% <0%> (+2.59%) ⬆️
daemon/mgr/events.go 91.78% <0%> (+2.73%) ⬆️
... and 12 more

Copy link
Contributor

@ZYecho ZYecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to add PullImage to SetUpTest, wdyt?

@fuweid
Copy link
Contributor Author

fuweid commented Mar 18, 2019

IMO, it's better to add PullImage to SetUpTest, wdyt?

This is case for image list. And I think we should pull image in one case because no case doesn't want it.

ping @ZYecho

@ZYecho
Copy link
Contributor

ZYecho commented Mar 18, 2019

LGTM

@allencloud allencloud merged commit b4ee6d6 into AliyunContainerService:master Mar 18, 2019
@fuweid fuweid deleted the me-update-test branch March 18, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants