Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrd: fix not set mediaType in manifest when commit image #2763

Merged
merged 1 commit into from
Mar 19, 2019
Merged

ctrd: fix not set mediaType in manifest when commit image #2763

merged 1 commit into from
Mar 19, 2019

Conversation

Ace-Tang
Copy link
Contributor

set mediaType when commit image from container

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

set mediaType when commit image from container

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2763 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2763      +/-   ##
==========================================
- Coverage   69.42%   69.34%   -0.09%     
==========================================
  Files         277      277              
  Lines       17412    17418       +6     
==========================================
- Hits        12089    12078      -11     
- Misses       4002     4012      +10     
- Partials     1321     1328       +7
Flag Coverage Δ
#criv1alpha2_test 39.39% <0%> (-0.03%) ⬇️
#integration_test_0 36.57% <0%> (ø) ⬆️
#integration_test_1 35.88% <100%> (+0.06%) ⬆️
#integration_test_2 36.49% <0%> (+0.01%) ⬆️
#integration_test_3 35.49% <0%> (-0.09%) ⬇️
#node_e2e_test 35.18% <0%> (-0.08%) ⬇️
#unittest 28.5% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
ctrd/image_commit.go 69.28% <100%> (+1.25%) ⬆️
ctrd/watch.go 77.46% <0%> (-5.64%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
ctrd/container.go 55.44% <0%> (-1.73%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 82.38% <0%> (-1.14%) ⬇️
daemon/mgr/container.go 60.75% <0%> (-0.21%) ⬇️
cri/v1alpha2/cri.go 71.5% <0%> (+0.25%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+2.38%) ⬆️

@Ace-Tang Ace-Tang requested a review from fuweid March 19, 2019 10:48
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit ec9a7aa into AliyunContainerService:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants