Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri: diable snapshotter usage collector by default #2769

Merged
merged 1 commit into from
Mar 26, 2019
Merged

cri: diable snapshotter usage collector by default #2769

merged 1 commit into from
Mar 26, 2019

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Mar 25, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Ⅰ. Describe what this PR did

If there is config for pouchd, the default value for command flag won't
work. For this case, we should change Disable to Enable.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

manually check.

Ⅴ. Special notes for reviews

If there is config for pouchd, the default value for command flag won't
work. For this case, we should change Disable to Enable.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@572c732). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2769   +/-   ##
=========================================
  Coverage          ?   69.37%           
=========================================
  Files             ?      277           
  Lines             ?    17429           
  Branches          ?        0           
=========================================
  Hits              ?    12092           
  Misses            ?     4009           
  Partials          ?     1328
Flag Coverage Δ
#criv1alpha2_test 39.37% <0%> (?)
#integration_test_0 36.58% <0%> (?)
#integration_test_1 35.75% <0%> (?)
#integration_test_2 36.51% <0%> (?)
#integration_test_3 35.54% <0%> (?)
#node_e2e_test 35.23% <0%> (?)
#unittest 28.52% <0%> (?)
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 71.63% <0%> (ø)

@rudyfly
Copy link
Collaborator

rudyfly commented Mar 26, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 26, 2019
@rudyfly rudyfly merged commit f9b29b5 into AliyunContainerService:master Mar 26, 2019
@fuweid fuweid deleted the me-disable-snapshot-collect branch June 4, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants