-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support filter format map[string]map[string]bool and change multi label filter to And match #2812
support filter format map[string]map[string]bool and change multi label filter to And match #2812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2812 +/- ##
==========================================
+ Coverage 69.34% 69.91% +0.56%
==========================================
Files 278 278
Lines 17397 17831 +434
==========================================
+ Hits 12064 12466 +402
- Misses 3983 4004 +21
- Partials 1350 1361 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0b0dc31
to
c324529
Compare
…el filter to AND match Signed-off-by: allen.wang <allen.wq@alipay.com>
c324529
to
6897026
Compare
could you explain why we need to change multi label filter to And match? the behavior in docker I think is OR match when use multi filter, should we be consistent with docker? @wangforthinker |
Any update on this? @wangforthinker |
Thanks for your question. As I know, label multi filter in docker is AND match. And the behavior is more suitable for daily usage habits. @ZYecho |
Yep I think you're right. the multi label filter was AND match, but multi reference/name filter was OR match. |
@HusterWan @allencloud Could you review this PR? |
|
Thanks for your contribution! At now there is no progress about this issue, so I think we can be consistent with docker. But can you explain about why we need support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Support filter format map[string]map[string]bool and change multi label filter to And match.
Ⅱ. Does this pull request fix one issue?
none.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add test.
Ⅳ. Describe how to verify it
by test.
Ⅴ. Special notes for reviews