Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create --env-file for pouch run & pouch create #2859

Closed
wants to merge 4 commits into from
Closed

create --env-file for pouch run & pouch create #2859

wants to merge 4 commits into from

Conversation

lang710
Copy link
Contributor

@lang710 lang710 commented May 23, 2019

Ⅰ. Describe what this PR did

create --env-file for pouch run & pouch create

Ⅱ. Does this pull request fix one issue?

try to fix #2857

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add unit test and simple integration test

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @lang710
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

❗ No coverage uploaded for pull request head (master@0c23a4d). Click here to learn what that means.
The diff coverage is n/a.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @lang710
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@lang710 lang710 changed the title fixes #2857 create --env-file for pouch run & pouch createfixes #2857 May 23, 2019
@lang710 lang710 changed the title create --env-file for pouch run & pouch createfixes #2857 create --env-file for pouch run & pouch create May 23, 2019
@CodeJuan
Copy link
Contributor

CodeJuan commented May 23, 2019

Hi @lang710
I was wondering if you could rebase & squash commits and signoff?

Signed-off-by: lang chi <21860405@zju.edu.cn>
@pouchrobot
Copy link
Collaborator

@lang710 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

ping @lang710
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pouch run support --env-file
4 participants