Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _counter in metrics name for counter type #2865

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 25, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

Ⅰ. Describe what this PR did

Currently pouch has some counter type metrics. But they all use suffix _counter_total. I think we should change these suffix to _total.
It is OK to just use _total here and it can represent counter. So this _counter is useless and should be removed.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #2865 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
- Coverage   69.09%   69.09%   -0.01%     
==========================================
  Files         285      285              
  Lines       17844    17844              
==========================================
- Hits        12330    12329       -1     
+ Misses       4114     4113       -1     
- Partials     1400     1402       +2
Flag Coverage Δ
#criv1alpha2_test 38.95% <ø> (-0.06%) ⬇️
#integration_test_0 36.58% <ø> (+0.01%) ⬆️
#integration_test_1 35.76% <ø> (ø) ⬆️
#integration_test_2 36.48% <ø> (+0.01%) ⬆️
#integration_test_3 35.48% <ø> (+0.02%) ⬆️
#node_e2e_test 34.77% <ø> (ø) ⬆️
#unittest 28.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pkg/utils/metrics/metrics.go 100% <ø> (ø) ⬆️
apis/metrics/metrics.go 100% <ø> (ø) ⬆️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 76.76% <0%> (-1.02%) ⬇️
ctrd/container.go 54.3% <0%> (+0.38%) ⬆️
ctrd/supervisord/daemon.go 50.67% <0%> (+1.35%) ⬆️
cri/ocicni/netns.go 60.81% <0%> (+2.7%) ⬆️

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @yeya24
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Signed-off-by: yeya24 <yb532204897@gmail.com>

fix unittest

Signed-off-by: yeya24 <yb532204897@gmail.com>

fix intergration test

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 force-pushed the fix/rename-counter-metrics branch from 3e321fe to 9c02ef7 Compare May 27, 2019 02:35
@yeya24 yeya24 closed this Dec 4, 2019
@yeya24 yeya24 deleted the fix/rename-counter-metrics branch December 4, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants