Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cli supports --env-file #2869

Closed
wants to merge 2 commits into from

Conversation

lang710
Copy link
Contributor

@lang710 lang710 commented May 27, 2019

Signed-off-by: Lang Chi 21860405@zju.edu.cn

Ⅰ. Describe what this PR did

pouch command supports --env-file

Ⅱ. Does this pull request fix one issue?

fixes #2857

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

unit test

Ⅳ. Describe how to verify it

cat /home/abc

env_var_name=another_value

pouch run --env-file=/home/abc -d busybox top

b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639

pouch exec b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639 env | grep env_var_name

env_var_name=another_value

Ⅴ. Special notes for reviews

Signed-off-by: Lang Chi <21860405@zju.edu.cn>
@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #2869 into master will decrease coverage by 1.69%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2869     +/-   ##
========================================
- Coverage   69.09%   67.4%   -1.7%     
========================================
  Files         285     285             
  Lines       17844   17844             
========================================
- Hits        12330   12028    -302     
- Misses       4114    4409    +295     
- Partials     1400    1407      +7
Flag Coverage Δ
#criv1alpha2_test 39% <ø> (ø) ⬆️
#integration_test_0 ?
#integration_test_1 35.73% <ø> (-0.03%) ⬇️
#integration_test_2 36.52% <ø> (+0.05%) ⬆️
#integration_test_3 35.43% <ø> (-0.02%) ⬇️
#node_e2e_test 34.7% <ø> (-0.08%) ⬇️
#unittest 28.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
hookplugins/containerplugin/update_hook.go 0% <0%> (-100%) ⬇️
daemon/mgr/container_upgrade.go 0% <0%> (-65.1%) ⬇️
builder/exporter.go 0% <0%> (-62.5%) ⬇️
storage/plugins/plugins.go 25% <0%> (-25%) ⬇️
daemon/builder.go 56.25% <0%> (-18.75%) ⬇️
pkg/utils/random_string.go 63.63% <0%> (-18.19%) ⬇️
daemon/mgr/container_envs.go 0% <0%> (-15.79%) ⬇️
storage/volume/driver/remote.go 51.78% <0%> (-14.29%) ⬇️
daemon/mgr/container_logs.go 68.75% <0%> (-13.75%) ⬇️
daemon/mgr/spec_linux.go 66.07% <0%> (-13.08%) ⬇️
... and 22 more

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @lang710
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Signed-off-by: Lang Chi <21860405@zju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pouch run support --env-file
2 participants