-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix invalid memory limit #2876
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
yeya24:fix/invalid-memory-limit
Jun 9, 2019
Merged
fix: fix invalid memory limit #2876
allencloud
merged 1 commit into
AliyunContainerService:master
from
yeya24:fix/invalid-memory-limit
Jun 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2876 +/- ##
==========================================
- Coverage 68.88% 68.85% -0.03%
==========================================
Files 291 291
Lines 18249 18251 +2
==========================================
- Hits 12571 12567 -4
+ Misses 4228 4227 -1
- Partials 1450 1457 +7
|
ZYecho
reviewed
Jun 2, 2019
yeya24
force-pushed
the
fix/invalid-memory-limit
branch
from
June 3, 2019 08:42
cf46141
to
5a7c233
Compare
LGTM |
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
fix/invalid-memory-limit
branch
from
June 5, 2019 15:29
5a7c233
to
854f0e0
Compare
Thanks a lot for your great work. Merging... @yeya24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Ⅰ. Describe what this PR did
Fix a bug about invalid memory limit.
Here are the outputs of these two stats commands. For pouch, the memory limit is very high, we must constrain this value max to machine memory.
Ⅱ. Does this pull request fix one issue?
No
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Currently no.
Ⅳ. Describe how to verify it
pouch stats [container]
Ⅴ. Special notes for reviews