Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy cmd support copy from networkMounts #2892

Closed
wants to merge 1 commit into from

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jun 4, 2019

Signed-off-by: zhangyue zy675793960@yeah.net

Ⅰ. Describe what this PR did

current impl doesn't support copy /etc/hosts or /etc/hostname from container, this pr fix it.

Ⅱ. Does this pull request fix one issue?

None.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

added.

Ⅳ. Describe how to verify it

wait for CI

Ⅴ. Special notes for reviews

None.

@pouchrobot pouchrobot added areas/network kind/bug This is bug report for project size/M labels Jun 4, 2019
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #2892 into master will decrease coverage by 0.63%.
The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2892      +/-   ##
==========================================
- Coverage    68.7%   68.06%   -0.64%     
==========================================
  Files         291      291              
  Lines       18238    18271      +33     
==========================================
- Hits        12530    12437      -93     
- Misses       4244     4344     +100     
- Partials     1464     1490      +26
Flag Coverage Δ
#criv1alpha2_test 38.28% <0%> (-0.09%) ⬇️
#integration_test_0 36.13% <0%> (-0.09%) ⬇️
#integration_test_1 35.72% <86.11%> (+0.07%) ⬆️
#integration_test_2 36.03% <0%> (-0.13%) ⬇️
#integration_test_3 ?
#node_e2e_test 34.07% <0%> (+0.01%) ⬆️
#unittest 27.99% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/container_copy.go 60% <86.11%> (+2.51%) ⬆️
daemon/logger/syslog/fmt.go 0% <0%> (-33.34%) ⬇️
daemon/mgr/image_load.go 39.13% <0%> (-17.4%) ⬇️
daemon/logger/syslog/syslog.go 59.34% <0%> (-16.49%) ⬇️
daemon/mgr/container_checkpoint.go 59.03% <0%> (-9.64%) ⬇️
apis/server/container_bridge.go 83.05% <0%> (-6.95%) ⬇️
apis/server/image_bridge.go 71.53% <0%> (-6.93%) ⬇️
daemon/mgr/volume.go 78.57% <0%> (-4.09%) ⬇️
daemon/mgr/container_logger.go 74.5% <0%> (-3.93%) ⬇️
daemon/logger/syslog/validate.go 52.63% <0%> (-3.16%) ⬇️
... and 15 more

Signed-off-by: zhangyue <zy675793960@yeah.net>
@pouchrobot
Copy link
Collaborator

ping @ZYecho
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@CLAassistant
Copy link

CLAassistant commented May 21, 2020

CLA assistant check)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement) before we can accept your contribution.


zhangyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck) it.

@fuweid fuweid closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants