-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: cli support --add-host #2919
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
+ Coverage 67.91% 68.09% +0.17%
==========================================
Files 291 291
Lines 18691 18387 -304
==========================================
- Hits 12694 12520 -174
+ Misses 4515 4399 -116
+ Partials 1482 1468 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lang710 a little suggestion, and also please fix CI issue. |
862324e
to
d3cb90a
Compare
feec26f
to
1727998
Compare
1a327b4
to
5aa0f25
Compare
need rebase |
Thanks a lot, I'll rebase it as soon as possible. |
|
edb10aa
to
8f59408
Compare
Signed-off-by: Lang Chi <21860405@zju.edu.cn>
Signed-off-by: Lang Chi 21860405@zju.edu.cn
Ⅰ. Describe what this PR did
feature: cli support --add-host
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Added
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews