Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pouch linter #2942

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 5, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

Ⅰ. Describe what this PR did

This PR update pouchlinter image.
Mirror PR for dragonflyoss/dragonfly#657
Related:

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

yeya24 added 2 commits July 5, 2019 20:09
Signed-off-by: yeya24 <yb532204897@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #2942 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2942      +/-   ##
=========================================
- Coverage   68.16%   68.1%   -0.07%     
=========================================
  Files         291     291              
  Lines       18343   18343              
=========================================
- Hits        12504   12492      -12     
- Misses       4381    4388       +7     
- Partials     1458    1463       +5
Flag Coverage Δ
#criv1alpha2_test 34.78% <100%> (ø) ⬆️
#integration_test_0 36.09% <0%> (-0.09%) ⬇️
#integration_test_1 35.54% <0%> (+0.02%) ⬆️
#integration_test_2 36.1% <0%> (-0.04%) ⬇️
#integration_test_3 35.58% <0%> (-0.02%) ⬇️
#node_e2e_test 34.19% <0%> (-0.08%) ⬇️
#unittest 27.96% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/stream/portforward/httpstream.go 70.94% <100%> (ø) ⬆️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
cri/ocicni/netns.go 58.1% <0%> (-2.71%) ⬇️
ctrd/container.go 51.62% <0%> (-1.53%) ⬇️
cri/ocicni/cni_manager.go 61.32% <0%> (-0.95%) ⬇️
daemon/mgr/container.go 59.93% <0%> (-0.42%) ⬇️
cri/v1alpha2/cri.go 64.03% <0%> (+0.25%) ⬆️
daemon/mgr/container_utils.go 77.77% <0%> (+1.51%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @yeya24
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your work. @yeya24

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 10, 2019
@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your work. @yeya24

@allencloud allencloud merged commit 48da05a into AliyunContainerService:master Jul 10, 2019
@yeya24 yeya24 deleted the update-pouchlinter branch July 10, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants