Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add pouch logs cli command #886

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

add logs cli command for pouch

Ⅱ. Does this pull request fix one issue?

fixes #865

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #886 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   14.51%   14.37%   -0.14%     
==========================================
  Files         116      117       +1     
  Lines        7034     7101      +67     
==========================================
  Hits         1021     1021              
- Misses       5926     5993      +67     
  Partials       87       87
Impacted Files Coverage Δ
client/container.go 0% <0%> (ø) ⬆️
cli/main.go 0% <0%> (ø) ⬆️
cli/logs.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8d7eb...4bead34. Read the comment docs.

@Letty5411
Copy link
Contributor

@HusterWan you may also need to add the subcmd in cli/main.go

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 15, 2018
@HusterWan HusterWan merged commit 9943ac1 into AliyunContainerService:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli areas/log kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature required] need API /container/{name:.*}/logs
4 participants