Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix cli_top_test test case #914

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan zirenwan@gmail.com

Ⅰ. Describe what this PR did

fix cli_top_test PouchTopSuite failed in alios

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Michael Wan <zirenwan@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #914 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   13.66%   13.66%           
=======================================
  Files         121      121           
  Lines        7667     7667           
=======================================
  Hits         1048     1048           
  Misses       6529     6529           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dbffe...6983e85. Read the comment docs.

@allencloud
Copy link
Collaborator

Does this work fine in AliOS?
Please add some result of that in the comment of this pr, @HusterWan
Thanks a lot.

@HusterWan
Copy link
Contributor Author

HusterWan commented Mar 17, 2018

Does this work fine in AliOS?

The answer is Yes, the reason why the test case failed is the ps -ef print title UID PID PPID C STIME TTY TIME CMD has different spaces number between each item on centos 7 and alios, so i trim all the space, and just compare the string UIDPIDPPID

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit fa50191 into AliyunContainerService:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants