Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Installation more compatible #930

Merged

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

Ⅰ. Describe what this PR did

I am using a VM on QingCloud to install Pouch. I found that when I copy the installation command to terminal of VM, it will paste some unexpected char, see:

root@i-qvufr3ii:~# sudo apt-get install \
> .apt-transport-https \
> .ca-certificates \
> .curl \
> .software-properties-common

In fact, . is out of expect.

So I update the installation.md to fix this to avoid unexpected behavior.

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S conflict/needs-rebase labels Mar 20, 2018
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@codecov-io
Copy link

Codecov Report

Merging #930 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   13.32%   13.32%           
=======================================
  Files         122      122           
  Lines        7872     7872           
=======================================
  Hits         1049     1049           
  Misses       6732     6732           
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273c660...1ccfbf0. Read the comment docs.

@allencloud
Copy link
Collaborator Author

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 21, 2018
@allencloud allencloud merged commit b1053a7 into AliyunContainerService:master Mar 21, 2018
@allencloud allencloud deleted the update-installation branch March 21, 2018 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants