feature: finish restart interface #944
Conversation
|
there is a problem: If start container too quickly after stop it, the snapshot of the container will be deleted by the containerd gc. this pr should not be merged utill i fix the problem |
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 13.16% 13.12% -0.04%
==========================================
Files 123 123
Lines 8175 8197 +22
==========================================
Hits 1076 1076
- Misses 7003 7025 +22
Partials 96 96
Continue to review full report at Codecov.
|
HusterWan
force-pushed
the
zr/finish-restart-interface
branch
from
0531fec
to
eb94d36
Compare
HusterWan
changed the title
i have figured it out: when stopping a container we should add lease in ctx to prevent the snapshot being deleted by gc. |
Signed-off-by: Michael Wan <zirenwan@gmail.com>
HusterWan
force-pushed
the
zr/finish-restart-interface
branch
from
eb94d36
to
59fa836
Compare
| if err := mgr.stop(ctx, c, timeout); err != nil { | ||
| return errors.Wrapf(err, "failed to stop container") | ||
| } | ||
| logrus.Debug("Restart: container " + c.ID() + " stopped succeeded") |
There was a problem hiding this comment.
we usually use logrus.Debugf() here.
|
LGTM |
pouchrobot
added
the
LGTM
Signed-off-by: Michael Wan zirenwan@gmail.com
Ⅰ. Describe what this PR did
finish restart interface daemon part
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews