Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix check kernel version is wrong #946

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Mar 22, 2018

Ⅰ. Describe what this PR did

check kernel version when setting disk quota driver, it should check
kernel > 4, instead of major > 4.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

For example,the version of kernel is 3.10, and it supports group quota. you can test like this:

# cd pouch/test
# go test -check.f TestAliKernelDiskQuotaWorks

test will be succeed.

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

check kernel version when setting disk quota driver, it should check
kernel > 4, instead of major > 4.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Mar 22, 2018
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 22, 2018
@codecov-io
Copy link

Codecov Report

Merging #946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   13.21%   13.21%           
=======================================
  Files         123      123           
  Lines        8145     8145           
=======================================
  Hits         1076     1076           
  Misses       6973     6973           
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079a92d...0b8cbf9. Read the comment docs.

@allencloud allencloud merged commit c770dad into AliyunContainerService:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants