bugfix: handle image format 'namespace/name:tag' correctly #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
image-fix
branch
3 times, most recently
from
63ed316
to
421d6b4
Compare
Could you add an integration test for the case? @YaoZengzeng |
Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 13.09% 13.09%
=======================================
Files 124 124
Lines 8354 8354
=======================================
Hits 1094 1094
Misses 7168 7168
Partials 92 92
Continue to review full report at Codecov.
|
|
@allencloud PTAL |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn
Ⅰ. Describe what this PR did
With this PR, we could pull image like "google/cadvisor:latest" correctly.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews