feature: add daemon update API #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
update-daemon-api
branch
5 times, most recently
from
9278b5c to
ad8a7ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
- Coverage 13.72% 13.68% -0.04%
==========================================
Files 124 124
Lines 8367 8387 +20
==========================================
Hits 1148 1148
- Misses 7120 7140 +20
Partials 99 99
Continue to review full report at Codecov.
|
allencloud
force-pushed
the
update-daemon-api
branch
2 times, most recently
from
3e3b051 to
c067255
Compare
HusterWan
reviewed
Mar 29, 2018
daemon/mgr/system.go
Outdated
| for _, newLabel := range cfg.Labels { | ||
| appearedKey := false | ||
| for i := 0; i < length; i++ { | ||
| newLabelSlice := strings.SplitN(newLabel, "=", 2) |
There was a problem hiding this comment.
this line should put in upper for.
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
update-daemon-api
branch
from
c067255 to
475cd57
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
This PR adds
POST /daemon/updateAPI to make daemon be able to be updated.Currently we can only update daemon's labels and image proxy. I encapsulate both two into a DaemonUpdateConfig struct and use this to pass through daemon and client.
This API has not a command line implementation yet.
Ⅱ. Does this pull request fix one issue?
fixes #983
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
see the integration test in code change
api_daemon_update_test.goⅤ. Special notes for reviews
none