feature: support multiple inspection #989

faycheng · 2018-03-28T14:00:12Z

Signed-off-by: 程飞 fay.cheng.cn@gmail.com

Ⅰ. Describe what this PR did

Support multiple inspection inspired by the issue #922

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

➜ pouch image inspect -f '{{.ID}}' 4493f9e1fd39 786f81bbee21
sha256:4493f9e1fd3990cc8e4ea30e8b9583a90b6596de488cd95284bf0df5823baf3e
sha256:786f81bbee21734ff4bd5b7e30edea495200a28e10c2999b50f553a816391284

Ⅴ. Special notes for reviews

allencloud · 2018-03-28T15:57:43Z

I am afraid that travisCI fails to run this PR, since there is one ci test missing.
Could you help to force push your branch with a minor change? @faycheng

Also cc @HusterWan @Letty5411 to see is there anything we could do to guarantee the CI testing.

faycheng · 2018-03-28T16:04:06Z

@allencloud Done

allencloud · 2018-03-28T16:05:32Z

cli/inspect/inspector.go

@@ -8,6 +8,7 @@ import (

 	"github.com/alibaba/pouch/pkg/utils/templates"

+	"fmt"


Please move this built package fmt to line L6 of this file and gofmt this file, since we have made a rule of

When importing packages, to improve readabilities, we should import package by sequence: system packages, project's own packages and third-party packages. And we should keep a blank line among these three kinds of packages;

In https://github.com/alibaba/pouch/blob/master/docs/contributions/code_styles.md#additional-style-rules

omg, I will solve it.
Thanks for your reminder.

allencloud · 2018-03-28T16:11:00Z

cli/image_inspect.go

-		RunE: func(cmd *cobra.Command, args []string) error {
-			return i.runInspect(args)
+		Args:  cobra.MinimumNArgs(1),
+		Run: func(cmd *cobra.Command, args []string) {


I do not think that change RunE into Run is correct. Here is my reason: we need to know whether this command works or not via RunE, since RunE would return an error or nil.

With Run, we cannot tell whether the command runs into error, this is a confusing situation for users. Users cannot use echo $? to judge if it runs well, since the exit code is always 0.

WDYT? @faycheng

Yes, you are right.I will rollback to RunE.

already updated change request, dismissing

allencloud · 2018-03-28T17:04:24Z

I am afraid that CI would fail since I think there is a bug in code base. PR #992 tries to fix this. You can ignore the failed cases which are described in #991 .

faycheng · 2018-03-28T17:10:13Z

Got it.
Thanks again.Good night.

allencloud · 2018-03-29T01:45:04Z

#992 has been merged. Please rebase your branch to the latest upstream/master and push it back again. Thanks. @faycheng

Signed-off-by: 程飞 <fay.cheng.cn@gmail.com>

codecov-io · 2018-03-29T03:44:26Z

Codecov Report

Merging #989 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   13.73%   13.72%   -0.02%     
==========================================
  Files         124      124              
  Lines        8358     8367       +9     
==========================================
  Hits         1148     1148              
- Misses       7111     7120       +9     
  Partials       99       99

Impacted Files	Coverage Δ
cli/volume.go	`9.43% <0%> (ø)`	⬆️
cli/image_inspect.go	`0% <0%> (ø)`	⬆️
cli/inspect/inspector.go	`58.46% <0%> (-9.4%)`	⬇️
cli/inspect.go	`0% <0%> (ø)`	⬆️
cli/network.go	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d7840...3fbfc80. Read the comment docs.

faycheng · 2018-03-29T04:03:37Z

@allencloud Done.
And are there any suggestions?Thanks.

HusterWan · 2018-03-29T04:40:04Z

cli/image_inspect.go

 		RunE: func(cmd *cobra.Command, args []string) error {
-			return i.runInspect(args)
+			return inspect.MultiInspect(args, i.runInspect)


I think we should call MultiInspect in runInspect, because we may have some context to deal with in the future, WDYT?

yes, the skill of dealing with context is necessary.and i will try to solve it.thanks.

allencloud · 2018-03-29T06:22:43Z

@faycheng Thanks for your work. We are planning that merge this PR and leave two others for you to finish:

Add integration test for pouch volume inspect, pouch image inspect, pouch network inspect like pouch inspect container1 container2;
Add context for this command

How about that?

allencloud · 2018-03-29T06:23:53Z

LGTM

faycheng · 2018-03-29T06:51:58Z

@allencloud Sorry for the late reply, because i stays very busy with my work on company.
And, actually i don't finish this pr, create a new pr for integration test and ctx, or revert this pr, which is better?

pouchrobot added kind/feature size/S labels Mar 28, 2018

faycheng force-pushed the multi-inspect branch from 469a01e to 5791df4 Compare March 28, 2018 15:10

pouchrobot added size/M and removed size/S labels Mar 28, 2018

faycheng force-pushed the multi-inspect branch from 5791df4 to 93a9afa Compare March 28, 2018 16:03

allencloud previously requested changes Mar 28, 2018

View reviewed changes

allencloud reviewed Mar 28, 2018

View reviewed changes

faycheng force-pushed the multi-inspect branch from 93a9afa to 360c300 Compare March 28, 2018 16:36

faycheng changed the title ~~feature: support multiple inspection~~ [WIP]feature: support multiple inspection Mar 28, 2018

faycheng force-pushed the multi-inspect branch 4 times, most recently from 7bc56ff to 46a4ff2 Compare March 28, 2018 16:52

faycheng force-pushed the multi-inspect branch from 46a4ff2 to 2f30fda Compare March 29, 2018 03:13

support multiple inspection

3fbfc80

Signed-off-by: 程飞 <fay.cheng.cn@gmail.com>

faycheng force-pushed the multi-inspect branch from 2f30fda to 3fbfc80 Compare March 29, 2018 03:25

faycheng changed the title ~~[WIP]feature: support multiple inspection~~ feature: support multiple inspection Mar 29, 2018

HusterWan reviewed Mar 29, 2018

View reviewed changes

pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 29, 2018

allencloud merged commit 98a9065 into AliyunContainerService:master Mar 29, 2018

faycheng mentioned this pull request Mar 29, 2018

feature: enhance multiple inspection #1010

Merged

pouchrobot mentioned this pull request Mar 30, 2018

Weekly Report of Pouch from 2018-03-23 to 2018-03-30 #1017

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support multiple inspection #989

feature: support multiple inspection #989

faycheng commented Mar 28, 2018 •

edited

Loading

allencloud commented Mar 28, 2018

faycheng commented Mar 28, 2018

allencloud Mar 28, 2018

faycheng Mar 28, 2018

allencloud Mar 28, 2018

faycheng Mar 28, 2018

allencloud commented Mar 28, 2018

faycheng commented Mar 28, 2018

allencloud commented Mar 29, 2018

codecov-io commented Mar 29, 2018 •

edited

Loading

faycheng commented Mar 29, 2018

HusterWan Mar 29, 2018

faycheng Mar 29, 2018

allencloud commented Mar 29, 2018

allencloud commented Mar 29, 2018

faycheng commented Mar 29, 2018

		@@ -8,6 +8,7 @@ import (

		"github.com/alibaba/pouch/pkg/utils/templates"

		"fmt"

feature: support multiple inspection #989

feature: support multiple inspection #989

Conversation

faycheng commented Mar 28, 2018 • edited Loading

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

allencloud commented Mar 28, 2018

faycheng commented Mar 28, 2018

allencloud Mar 28, 2018

Choose a reason for hiding this comment

faycheng Mar 28, 2018

Choose a reason for hiding this comment

allencloud Mar 28, 2018

Choose a reason for hiding this comment

faycheng Mar 28, 2018

Choose a reason for hiding this comment

allencloud commented Mar 28, 2018

faycheng commented Mar 28, 2018

allencloud commented Mar 29, 2018

codecov-io commented Mar 29, 2018 • edited Loading

Codecov Report

faycheng commented Mar 29, 2018

HusterWan Mar 29, 2018

Choose a reason for hiding this comment

faycheng Mar 29, 2018

Choose a reason for hiding this comment

allencloud commented Mar 29, 2018

allencloud commented Mar 29, 2018

faycheng commented Mar 29, 2018

faycheng commented Mar 28, 2018 •

edited

Loading

codecov-io commented Mar 29, 2018 •

edited

Loading