Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depthmap metadata issue in DepthMapFiltering node #1466

Closed
almarouk opened this issue Jun 14, 2023 · 1 comment · Fixed by #1467
Closed

Depthmap metadata issue in DepthMapFiltering node #1466

almarouk opened this issue Jun 14, 2023 · 1 comment · Fixed by #1467
Assignees
@almarouk

Comments

@almarouk
Copy link
Member

almarouk commented Jun 14, 2023 •
edited
Loading

Description

Some metadata are missing when reading depthmaps in DepthMapFiltering, notably minDepth and maxDepth.

This issue has been observed approximately since Monday 12th June 2023.

Analysis

First impression

It's possible that the changes introduced in #1351 are causing the problem. Further investigation is required

Further analysis

It appears that the problem is in the following condition:

AliceVision/src/aliceVision/mvsUtils/mapIO.cpp

Line 480 in a2b9e03

if(fileType == EFileType::depthMap)

@almarouk almarouk self-assigned this Jun 14, 2023
@almarouk
Copy link
Member Author

@fabiencastan @mugulmd

@almarouk almarouk mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almarouk almarouk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mvsUtils] fix writing metadata for filtered depthmaps alicevision/AliceVision
1 participant
@almarouk