-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Dependencies #1182
Merged
Merged
Graph Dependencies #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input attribute to input attribute connection is not a real dependency between the nodes.
yann-lty
reviewed
Dec 18, 2020
- Avoid variation in dash pattern when the stroke is hovered by compensating strokeWidth. - Use a dash pattern of [6,4] to get a stronger feeling of a dashed line (VS a dotted line).
fabiencastan
force-pushed
the
dev/graphDeps
branch
from
December 28, 2020 15:19
73902e4
to
5fb6a5f
Compare
Also allow to expand attributes list on a locked node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection from an input attribute to another input attribute does not represent a real dependency between the nodes: the 2nd node does not need to have the 1st node computed.
This PR adds the option
dependenciesOnly
to many graph functions to choose if we want to manipulate the user graph or the dependency graph.With this PR many actions like duplicate nodes, remove nodes, remove data, etc are applied only to the dependency graph.