Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Dependencies #1182

Merged
merged 15 commits into from
Jan 4, 2021
Merged

Graph Dependencies #1182

merged 15 commits into from
Jan 4, 2021

Conversation

fabiencastan
Copy link
Member

Connection from an input attribute to another input attribute does not represent a real dependency between the nodes: the 2nd node does not need to have the 1st node computed.
This PR adds the option dependenciesOnly to many graph functions to choose if we want to manipulate the user graph or the dependency graph.

With this PR many actions like duplicate nodes, remove nodes, remove data, etc are applied only to the dependency graph.

Input attribute to input attribute connection is not a real dependency between the nodes.
@fabiencastan fabiencastan added this to the Meshroom 2020.2.0 milestone Dec 14, 2020
@fabiencastan fabiencastan requested review from a user and yann-lty December 18, 2020 00:19
- Avoid variation in dash pattern when the stroke is hovered by compensating strokeWidth.
- Use a dash pattern of [6,4] to get a stronger feeling of a dashed line (VS a dotted line).
@fabiencastan fabiencastan merged commit c502ee1 into develop Jan 4, 2021
@fabiencastan fabiencastan deleted the dev/graphDeps branch January 4, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants