Add option to include 'unknown' feature types in ConvertSfMFormat #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversion of dense point clouds via ConvertSfMFormat
fabiencastan
approved these changes
Aug 20, 2019
|
@pramukta, |
|
Sorry for the delay in merging that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ability to output dense point clouds via AliceVision's meshing utility produces an Alembic file that seems to look identical to the normal SfM Alembic files except that the
mvgPointCloudentries have their feature type set tounknown. However, this option isn't set as one of the parameters in theConvertSfMFormatmeshroom wrapper. As a result the node always strips out the points. Adding an "unknown" feature type option to the wrapper allows the dense cloud to be converted properly.If there's a better way, or a different change needed to save dense clouds to non-Alembic formats let me know and can take a look. Thanks for all the great work on AliceVision, I'm a huge fan.