Import ABC from collections.abc #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! We still have to support Python-2 to be able to submit job on Tractor renderfarm which, unfortunately, still doesn't have a python-3 api. |
|
I thought the repo was Python 3 only due to commit : 80d028e . I have added compatibility code to ensure the PR works with Python 2 and 3 . |
|
Perfect, thanks! |
|
codacy reports that imports are not used but the file is for compatibility code. asserts are skipped but it was previous code and doesn't seem to be relevant to this PR. |
fabiencastan
approved these changes
Jul 16, 2020
|
Thanks @fabiencastan :) |
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #982 . Import collections from collections.abc . Compatibility code is not added since Python 2 support has ended.