[BUG] Brew uninstall command won't execute after uninstall

[L1cardo]

If the close after uninstall option is on, the auto brew uninstall command won't execute.

Also I have found some other bugs:

1. CLI support can't be enabled, and here is the error log
   
   
2. close after uninstall says it will only affect when Pearcleaner is opened via Finder extension, but if I open the app normally , it will also close itself after uninstall.
   

[alienator88]

Okay, I think I have all of them fixed on my end except for the CLI one.
When the CLI is enabled, all it does is it creates a symlink to the pearcleaner binary and links it to the /usr/local/bin folder.

So the full command would be:
ln -s '/Applications/Pearcleaner/Contents/MacOS/Pearcleaner' '/usr/local/bin/pearcleaner'

When you recorded the logs, did you enable, disable or both, the CLI toggle?
Can you record toggling it on and off?
When it's successful, the logs should show this:

Symlink created successfully at /usr/local/bin/pearcleaner.
Symlink removed successfully from /usr/local/bin/pearcleaner.

[L1cardo]

The above picture is when it's on.
The log shows nothing when I turn it off.

[alienator88]

I'm guessing you don't have a pearcleaner binary at /usr/local/bin/pearcleaner at the moment?

The error in the screenshot seems to point out that it tried to remove the symlink but it didn't exist:

Which it shouldn't do because it runs a check to see if the symlink exists first and only executes it if it exists:

Pearcleaner/Pearcleaner/Logic/Utilities.swift

Line 71 in 8ed2de9

func manageSymlink(install: Bool) {

[L1cardo]

I don't even have this directory /usr/local/bin/, I only have /usr/local/

And here is the video

2024-11-27.7.54.08.mov

[alienator88]

That's kind of wild, I haven't seen anyone without that bin folder before. I thought it was default on macOS.
I bet if you run this in terminal and then try Pearcleaner CLI toggle again, it should work:
sudo mkdir /usr/local/bin

I might need to add a catch and check that the folder exists before running the symlink commands.

[L1cardo]

That's kind of wild, I haven't seen anyone without that bin folder before. I thought it was default on macOS. I bet if you run this in terminal and then try Pearcleaner CLI toggle again, it should work: sudo mkdir /usr/local/bin

I might need to add a catch and check that the folder exists before running the symlink commands.

Yeah, it worked after sudo mkdir /usr/local/bin

[alienator88]

Awesome, thanks for confirming!
I added a check to make sure the folder exists first before trying to symlink it there. That should avoid this issue in the future.
Can you try this test build and see if your other issues are resolved as well?
Pearcleaner.zip

[L1cardo]

Tried your test build and the latest release build, if I uninstall an app from Finder extension, the brew uninstall command won't trigger.

[alienator88]

Ughh..hmm..I just tested it now and it came right up with terminal and brew cleaned the app once I clicked uninstall.
You have brew cleanup setting enabled still?

Maybe record it and show me what you get.

[L1cardo]

Log shows nothing special

2024-11-28.8.03.43.mov

[alienator88]

Ahh, it's the close after uninstall setting preventing it still.
It seems there's a race condition, I'll figure it out and push out another update after the holidays.
I want to refactor the uninstall logic and make it cleaner anyways.

[alienator88]

Actually, can you try this when you have a moment? I was able to work on it a bit.
Pearcleaner.zip

[L1cardo]

Yeah, now it works

[alienator88]

I'll have this out in the next patch release.