Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Function #24

Open
9 tasks
gregorsart opened this issue Nov 14, 2023 · 4 comments
Open
9 tasks

Favorite Function #24

gregorsart opened this issue Nov 14, 2023 · 4 comments

Comments

@gregorsart
Copy link
Collaborator

gregorsart commented Nov 14, 2023

Value proposition

As a user I want to save my favorited dogs,

in order to create an individual collection.

Description

Image
Image

Acceptance criteria

  • By clicking the favorite button, the chosen dog is marked with a filled heart.
  • All favorited dogs are also shown on a separate favorite-dogs page.
  • You can toggle the favorite button on the favorite-dogs page as well as on the detail-page.
  • The favorite-dogs page is always reachable even if the app is reloaded.

Tasks

  • Create feature branch favorite-function-v2.
  • Create Favorite component.
  • Create favorite-dogs page.
  • Use local storage which contains all favorited dogs by the user.
  • Use AllDogsCard to display favorited dogs on the favorite-dogs page.
@gregorsart gregorsart moved this to 📋 Product Backlog in dog-app Nov 14, 2023
@gregorsart gregorsart changed the title Favorite Function Favorite Function // Detail Page Nov 14, 2023
@alinarub alinarub moved this from 📋 Product Backlog to 🎯 Sprint Backlog in dog-app Nov 15, 2023
@alinarub alinarub changed the title Favorite Function // Detail Page Favorite Function Nov 22, 2023
@ykolomytseva
Copy link

ykolomytseva commented Nov 22, 2023

Hiiiii, @gregorsart @alinarub @AchimBartscht !
Great app so far, all dogs are cute. 🐕
Just a few suggestions for this user story from my team to make it a little clearer:

  • Value Proposition =>
    As a user,
    I want to save my favorited dogs,
    In order to create an individual collection.
  • It would be cool, if you could add an extra image to show how your favorite-dogs page would look like
  • Maybe you could remove it at all or write it differently: The user can always go back to their favorited dogs, they are stored even if the browser closes =>
    Favorite-dogs page is always reachable even by reloading the app
  • small tip: maybe you would consider to add a favorite button on All Dogs page, to make the process more user friendly and save time, so user won`t have to click on description and read details and then can do this later. 🐩

@AchimBartscht
Copy link
Collaborator

AchimBartscht commented Nov 23, 2023

Hi Yana, thank you for reviewing. For now we have decided not to add a favorite button to the All Dogs Page. If we still have time later on, we might creagte another user story.

@Philipp-Hess
Copy link

Well done 👍 Looks good to me.

@gregorsart gregorsart moved this from 🎯 Sprint Backlog to ⚙️ In Progress in dog-app Dec 4, 2023
@alinarub alinarub moved this from ⚙️ In Progress to 🔬 Code Review in dog-app Dec 4, 2023
@alinarub
Copy link
Owner

alinarub commented Dec 5, 2023

We decided not to display hearts on the dog cards because they already link to the detail page. Also, we didn't add Favorites on the navigation menu because we built this on an older branch that still needed refactoring, we'll add it later. You can view the page by adding /favorite-dogs to the url.

@alinarub alinarub moved this from 🔬 Code Review to 🕵️‍♀️ Quality Assurance in dog-app Dec 5, 2023
@alinarub alinarub moved this from 🕵️‍♀️ Quality Assurance to ✨ Done in dog-app Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✨ Done
Development

No branches or pull requests

5 participants