New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

对ColumnValue的处理不符合plainbuff的定义规范 #84

Open

shaoxp opened this issue Aug 11, 2021 · 1 comment

shaoxp commented Aug 11, 2021

aliyun-tablestore-go-sdk/tablestore/plain_buffer.go

Line 308 in 984e92d

value.Type = ColumnType_INTEGER

这里面的读，对与int/double等类型，没有读/跳过 len字段．　我查这个repo中，对于ColumnValue写，也奇怪的多写len＋type+value的值，和读根本不对应．．

不知道是以ｃｏｄｅ中这种非对称的写法是对的，还是按照plainbuffer的规范定义操作是对的．唉．

Author

shaoxp commented Aug 11, 2021

需要以code为准，这里会省４个字节，但是引入很多分支．

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment