Skip to content

Commit

Permalink
fix: _resumeMultipart not use yield
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterRao committed Mar 30, 2018
1 parent 2b0967f commit ba2382b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/browser/managed_upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ proto._resumeMultipart = function* _resumeMultipart(checkpoint, options) {
}

// start uploads jobs
const errors = this._thunkPool(jobs, parallel);
const errors = yield this._thunkPool(jobs, parallel);
multipartFinish = true;

// check errors after all jobs are completed
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"url": "https://github.com/aliyun/oss-nodejs-sdk/issues"
},
"engines": {
"node": ">=4"
"node": ">=6"
},
"homepage": "https://github.com/aliyun/oss-nodejs-sdk",
"devDependencies": {
Expand Down Expand Up @@ -82,7 +82,6 @@
"karma-mocha": "^1.3.0",
"mm": "^2.0.0",
"mocha": "^3.5.3",
"platform": "^1.3.4",
"promise-polyfill": "^6.0.2",
"should": "^11.0.0",
"sinon": "^1.17.7",
Expand Down
2 changes: 1 addition & 1 deletion task/browser-test-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function build(options, callback) {
}).bundle(function(err, data) {
if (err) return callback(err);
var code = (data || '').toString();
fs.unlink(stsConfFile);
fs.unlinkSync(stsConfFile);
callback(null, code);
});
});
Expand Down
1 change: 0 additions & 1 deletion test/browser/browser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ describe('browser', () => {
yield new Promise((resolve) => {
const fr = new FileReader();
fr.onload = function () {
console.log(fr.result);
assert.equal(resultGet.content.toString(), fr.result);
resolve();
};
Expand Down

0 comments on commit ba2382b

Please sign in to comment.