fix: remove node enviroment x-oss-user-agent (#987)

ali-sdk · Sep 27, 2021 · fe39041 · fe39041
1 parent 6f3b456
commit fe39041
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -223,7 +223,7 @@ async function request(params) {
     result.data = await this.parseXML(result.data);
   }
   return result;
-};
+}
 
 proto._getResource = function _getResource(params) {
   let resource = '/';

diff --git a/lib/common/utils/createRequest.js b/lib/common/utils/createRequest.js
@@ -25,8 +25,10 @@ function createRequest(params) {
     }
     const headers = {
         'x-oss-date': dateFormat(date, 'UTC:ddd, dd mmm yyyy HH:MM:ss \'GMT\''),
-        'x-oss-user-agent': this.userAgent
     };
+    if (typeof window !== 'undefined') {
+        headers['x-oss-user-agent']= this.userAgent
+    }
     if (this.userAgent.includes('nodejs')) {
         headers['User-Agent'] = this.userAgent;
     }

diff --git a/lib/common/utils/createRequest.ts b/lib/common/utils/createRequest.ts
@@ -12,7 +12,7 @@ const { getReqUrl } = require('../client/getReqUrl');
 interface Headers {
   [propName: string]: any
   'x-oss-date': string,
-  'x-oss-user-agent': string,
+  'x-oss-user-agent'?: string,
 }
 
 interface ReqParams {
@@ -35,9 +35,12 @@ export function createRequest(this: any, params) {
   }
   const headers: Headers = {
     'x-oss-date': dateFormat(date, 'UTC:ddd, dd mmm yyyy HH:MM:ss \'GMT\''),
-    'x-oss-user-agent': this.userAgent
   };
 
+  if (typeof window !== 'undefined') {
+    headers['x-oss-user-agent'] = this.userAgent;
+  }
+
   if (this.userAgent.includes('nodejs')) {
     headers['User-Agent'] = this.userAgent;
   }