feat: support callback options for put and multipartUpload #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterRao
reviewed
Mar 2, 2018
README.md
Outdated
| - [callbackHost] {String} The host header value for initiating callback requests. | ||
| - callbackBody {String} The value of the request body when a callback is initiated, for example, key=$(key)&etag=$(etag)&my_var=$(x:my_var). | ||
| - [callbackBodyType] {String} The Content-Type of the callback requests initiatiated, It supports application/x-www-form-urlencoded and application/json, and the former is the default value. | ||
| - [callbackVar] {Object} Custom parameters are a map of key-values<br> |
There was a problem hiding this comment.
合并callbackVar到 callback里面
| @@ -793,29 +793,21 @@ parameters: | |||
| - [mime] {String} custom mime, will send with `Content-Type` entity header | |||
| - [meta] {Object} user meta, will send with `x-oss-meta-` prefix string | |||
| e.g.: `{ uid: 123, pid: 110 }` | |||
| - [callback] {Object} The callback parameter is composed of a JSON string encoded in Base64,detail [see](https://www.alibabacloud.com/help/doc-detail/31989.htm)<br> | |||
There was a problem hiding this comment.
callback里面参数省略 callback 前缀
test/browser.tests.js
Outdated
| describe('browser', function () { | ||
| before(function* () { | ||
| ossConfig = { | ||
| region: stsConfig.region, | ||
| accessKeyId: stsConfig.Credentials.AccessKeyId, | ||
| accessKeySecret: stsConfig.Credentials.AccessKeySecret, | ||
| stsToken: stsConfig.Credentials.SecurityToken, | ||
| bucket: stsConfig.bucket | ||
| bucket: stsConfig.bucket, | ||
| callbackServer: 'http://oss-demo.aliyuncs.com:23450' //oss demo callback server an ecs, used with PutObject、PostObject、CompleteMultipartUpload |
There was a problem hiding this comment.
callbackServer 最为配置变量移到别处，会给开发者造成困惑。
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
===========================================
- Coverage 96.26% 24.45% -71.81%
===========================================
Files 12 13 +1
Lines 1552 1574 +22
Branches 293 299 +6
===========================================
- Hits 1494 385 -1109
- Misses 58 1189 +1131
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.support callback options for put and multipartUpload