Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug about value of requestTimeout! #383

Merged
merged 2 commits into from
Mar 9, 2018
Merged

fix: fix bug about value of requestTimeout! #383

merged 2 commits into from
Mar 9, 2018

Conversation

duan007a
Copy link
Contributor

@duan007a duan007a commented Mar 9, 2018

fix: fix bug about value of requestTimeout!

@codecov-io
Copy link

Codecov Report

Merging #383 into master will decrease coverage by 72.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #383       +/-   ##
===========================================
- Coverage   96.56%   24.45%   -72.11%     
===========================================
  Files          13       13               
  Lines        1574     1574               
  Branches      299      299               
===========================================
- Hits         1520      385     -1135     
- Misses         54     1189     +1135
Impacted Files Coverage Δ
lib/common/callback.js 6.25% <0%> (-93.75%) ⬇️
lib/common/multipart-copy.js 7.92% <0%> (-91.09%) ⬇️
lib/common/multipart.js 10.71% <0%> (-88.1%) ⬇️
lib/bucket.js 12.28% <0%> (-85.97%) ⬇️
lib/object.js 12.76% <0%> (-84.05%) ⬇️
lib/managed_upload.js 13.98% <0%> (-82.52%) ⬇️
lib/rtmp.js 14.01% <0%> (-76.64%) ⬇️
lib/cluster.js 23.07% <0%> (-76.16%) ⬇️
lib/common/thunkpool.js 25% <0%> (-73.08%) ⬇️
lib/sts.js 28.37% <0%> (-66.22%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cd717...521c20a. Read the comment docs.

@PeterRao PeterRao merged commit a3653a7 into ali-sdk:master Mar 9, 2018
@duan007a duan007a deleted the fix/change_timeout_behavior branch March 13, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants