Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove replace %20 to '+' #489

Merged
merged 2 commits into from
Jun 13, 2018
Merged

fix: remove replace %20 to '+' #489

merged 2 commits into from
Jun 13, 2018

Conversation

luozhang002
Copy link
Contributor

fix: remove replace %20 to '+'

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          13       13           
  Lines        1432     1432           
  Branches      273      273           
=======================================
  Hits         1388     1388           
  Misses         44       44
Impacted Files Coverage Δ
lib/client.js 92.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf546ce...633d905. Read the comment docs.

@binghaiwang binghaiwang merged commit 22363d0 into master Jun 13, 2018
Copy link
Collaborator

@PeterRao PeterRao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 请添加测试用例,代码注释也需要更新,代码注释也是sdk的一部分,需要重视下。
  2. 提交者信息,更新github的账号

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants