Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: common initOptions #669

Closed
wants to merge 2 commits into from
Closed

refactor: common initOptions #669

wants to merge 2 commits into from

Conversation

PeterRao
Copy link
Collaborator

@PeterRao PeterRao commented Oct 23, 2019

refactor: common initOptions
feat: disable fetch for borwoser

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #669 into master will decrease coverage by 72.37%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #669       +/-   ##
===========================================
- Coverage   91.19%   18.81%   -72.38%     
===========================================
  Files          14       15        +1     
  Lines        1635     1637        +2     
  Branches      341      341               
===========================================
- Hits         1491      308     -1183     
- Misses        144     1329     +1185
Impacted Files Coverage Δ
lib/common/utils/checkBucketName.js 25% <ø> (ø)
lib/bucket.js 10.86% <100%> (-87.32%) ⬇️
lib/client.js 44.87% <100%> (-47.5%) ⬇️
lib/common/client/initOptions.js 93.93% <93.93%> (ø)
lib/common/multipart-copy.js 8.42% <0%> (-89.48%) ⬇️
lib/common/multipart.js 10.3% <0%> (-87.63%) ⬇️
lib/object.js 12.27% <0%> (-85.2%) ⬇️
lib/managed-upload.js 11.56% <0%> (-81.64%) ⬇️
lib/rtmp.js 13.33% <0%> (-77.15%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f49ff3...a04242c. Read the comment docs.

@PeterRao PeterRao closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant