Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension. #6861

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

fuliu-zln
Copy link
Contributor

No description provided.

@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch 8 times, most recently from 55adb96 to d60483d Compare January 15, 2024 07:08
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scalingrule: add an attribute alarm_dimension resource/alicloud_ess_scalingrule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scaling_rule_test; docs: deprecate resource_alicloud_ess_scaling_rule Jan 15, 2024
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch from d60483d to f38d10a Compare January 15, 2024 07:17
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scalingrule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scaling_rule_test; docs: deprecate resource_alicloud_ess_scaling_rule resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scaling_rule_test; docs: deprecate resource_alicloud_ess_scaling_rule Jan 15, 2024
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scaling_rule_test; docs: deprecate resource_alicloud_ess_scaling_rule resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scalingrule_test; docs: deprecate resource_al icloud_ess_scalingrule Jan 15, 2024
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scalingrule_test; docs: deprecate resource_al icloud_ess_scalingrule resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scalingrule_test; docs: deprecate resource_alicloud_ess_scalingrule Jan 15, 2024
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch 2 times, most recently from 22c6791 to 32ed18a Compare January 15, 2024 07:28
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: deprecate resource_alicloud_ess_scalingrule_test; docs: deprecate resource_alicloud_ess_scalingrule resource/alicloud_ess_scalingrule: add an attribute alarm_dimension Jan 15, 2024
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch from 32ed18a to 9718f66 Compare January 15, 2024 07:39
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scalingrule: add an attribute alarm_dimension resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: rename alicloud/{resource_alicloud_ess_scalingrule_test.go => resource_alicloud_ess_scaling_rule_test.go}; docs: rename alicloud/{resource_alicloud_ess_scalingrule.go => resource_alicloud_ess_scaling_rule.go} Jan 15, 2024
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch from 9718f66 to 73c2e9a Compare January 15, 2024 07:46
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension;docs: rename alicloud/{resource_alicloud_ess_scalingrule_test.go => resource_alicloud_ess_scaling_rule_test.go}; docs: rename alicloud/{resource_alicloud_ess_scalingrule.go => resource_alicloud_ess_scaling_rule.go} docs: rename alicloud/{resource_alicloud_ess_scalingrule_test.go => resource_alicloud_ess_scaling_rule_test.go}; docs: rename alicloud/{resource_alicloud_ess_scalingrule.go => resource_alicloud_ess_scaling_rule.go};resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension Jan 15, 2024
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch 2 times, most recently from 688a77d to e391cc2 Compare January 15, 2024 10:03
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch from e391cc2 to 4f98578 Compare January 16, 2024 10:27
…esource_alicloud_ess_scaling_rule_test.go}; docs: rename alicloud/{resource_alicloud_ess_scalingrule.go => resource_alicloud_ess_scaling_rule.go};resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension
@fuliu-zln fuliu-zln force-pushed the feat/add_alarmDimension branch from 4f98578 to 2c00de1 Compare January 16, 2024 10:31
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ChenHanZhang ChenHanZhang merged commit 43c6e66 into aliyun:master Jan 19, 2024
19 checks passed
@ChenHanZhang ChenHanZhang changed the title docs: rename alicloud/{resource_alicloud_ess_scalingrule_test.go => resource_alicloud_ess_scaling_rule_test.go}; docs: rename alicloud/{resource_alicloud_ess_scalingrule.go => resource_alicloud_ess_scaling_rule.go};resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension resource/alicloud_ess_scaling_rule: add an attribute alarm_dimension. Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants